6.x: rename conflicting underscored methods#313
Conversation
| ], | ||
| 'Cake\ORM\Query\SelectQuery' => [ | ||
| '_decorateResults' => 'ormDecorateResults', | ||
| '_execute' => 'ormExecute', |
There was a problem hiding this comment.
i added the orm prefix since both those methods exist in the \Cake\Database\Query\SelectQuery as well.
|
The E.g. |
We can just move the code inside the non prefixed methods and get rid of the prefixed ones for these. |
yes, thats what I like to do as well. |
* rename conflicting underscored methods * adjust naming according to feedback
Refs: #310
This contains all the method renames, which can't be simply changed to the non-underscore-prefixed version.
Therefore please feel free to add reviews for new method names.
The
doXschema for all the sub-method naming feels right to me, but maybe someone has a better idea 😁